Hi Krzysztof, Thank you for the review. On Tue, Feb 7, 2023 at 2:35 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 07/02/2023 14:09, bchihi@xxxxxxxxxxxx wrote: > > From: Balsam CHIHI <bchihi@xxxxxxxxxxxx> > > > > Add LVTS thermal controllers dt-binding definition for mt8192 and mt8195. > > > > > > +allOf: > > + - $ref: thermal-sensor.yaml# > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - mediatek,mt8192-lvts-ap > > + - mediatek,mt8192-lvts-mcu > > + then: > > + properties: > > + nvmem-cells: > > + maxItems: 1 > > + > > + nvmem-cell-names: > > + maxItems: 1 > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - mediatek,mt8195-lvts-ap > > + - mediatek,mt8195-lvts-mcu > > + then: > > + properties: > > + nvmem-cells: > > minItems: 2 > OK, I will do the change. > > + maxItems: 2 > > + > > + nvmem-cell-names: > > minItems: 2 > OK, I will do this change too. > > + maxItems: 2 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > (...) > > > diff --git a/include/dt-bindings/thermal/mediatek,lvts-thermal.h b/include/dt-bindings/thermal/mediatek,lvts-thermal.h > > new file mode 100644 > > index 000000000000..4f2082065a31 > > --- /dev/null > > +++ b/include/dt-bindings/thermal/mediatek,lvts-thermal.h > > @@ -0,0 +1,19 @@ > > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > > +/* > > + * Copyright (c) 2023 MediaTek Inc. > > + * Author: Balsam CHIHI <bchihi@xxxxxxxxxxxx> > > + */ > > + > > +#ifndef __MEDIATEK_LVTS_DT_H > > +#define __MEDIATEK_LVTS_DT_H > > + > > +#define MT8195_MCU_BIG_CPU0 0 > > +#define MT8195_MCU_BIG_CPU1 1 > > +#define MT8195_MCU_BIG_CPU2 2 > > +#define MT8195_MCU_BIG_CPU3 3 > > +#define MT8195_MCU_LITTLE_CPU0 4 > > These changed for some reason. Why? The indentation is now broken > (although not visible above quote, but visible in diff and code). I thought that I fixed the indentation. I will restore it. > > Best regards, > Krzysztof > Best regards, Balsam
