On 25/01/2023 13:35, Aradhya Bhatia wrote:
Add support for the DSS controller on TI's new AM625 SoC in the tidss driver. The first video port (VP0) in am625-dss can output OLDI signals through 2 OLDI TXes. A 3rd output port has been added with "DISPC_PORT_OLDI" bus type.
Not a big thing here as you add support for a new SoC, but the ordering of the patches is not optimal. Here you add the AM625 DSS support, but then you continue actually adding the DSS support (well, mainly OLDI) in the following patches.
I think patch 6 could be before this patch. Parts of patch 4 could also be before this patch. The AM65X renames from patch 5 could be before this patch.
I'm mainly thinking of a case where someone uses AM625 and is bisecting a problem. What happens if his board uses OLDI, and he happens to hit one of these patches during bisect? If the display just stays black, but otherwise everything works fine, then no problem. But if it crashes or starts spamming sync losts or such or gives errors, it's not so nice.
Tomi
