On Wed, Feb 01, 2023 at 04:50:56PM +0100, Krzysztof Kozlowski wrote: > Correct the number of GPIOs in TLMM pin controller. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index fa2d0d7d1367..17e8c26a9ae6 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -3533,7 +3533,7 @@ tlmm: pinctrl@f100000 { > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > - gpio-ranges = <&tlmm 0 0 230>; > + gpio-ranges = <&tlmm 0 0 228>; > }; I verified that this count matches what's in downstream. Reviewed-by: Brian Masney <bmasney@xxxxxxxxxx> However, I noticed in upstream that we're using this reg property: reg = <0 0x0f100000 0 0x300000>; Downstream has a different base address and a wider size. Note: I added spaces for easy comparison. reg = < 0x0F000000 0x1000000>; I don't have access to the appropriate documents to see which is correct. I assume the base address in upstream is at least correct since pinctrl is working on this platform. Brian