On Wed, 1 Feb 2023, at 23:58, Clay Chang wrote: > Hi Andrew, > > On Tue, Jan 31, 2023 at 09:46:42PM +0800, Clay Chang wrote: >> > I'm trying to understand whether we can find some common ground with >> > controlling e.g. Aspeed's BMCs LPC peripherals based on Arnd's query[1], >> > but the description is a bit too vague right now for me to be able to do >> > that. >> > >> > [1] https://lore.kernel.org/all/66ef9643-b47e-428d-892d-7c1cbd358a5d@xxxxxxxxxxxxxxxx/ >> > >> > Andrew > > I briefly studied driver/soc/aspeed/aspeed-lpc-ctrl.c, and IMO the > similarity between HPE GXP driver and Aspeed's could be that we both > expose the LPC memory addresses or registers for configuration purposes. > However, the functions to be configured could vary. There are a few sets > of registers that HPE wants to expose for configuration in the future. The talk of "exposing registers" feels concerning - we're trying not to do that directly. Instead we want to lift out an API that constrains the behaviour a bit but works for both of us if there's overlap in functionality. Can you point to any documentation of the behaviour of your hardware? It's still a little vague to me. Andrew