Re: [PATCH V10 2/6] i2c: nvidia-gpu: Add ACPI property to align with device-tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



H Wolfram,

On 31/01/2023 17:57, Jon Hunter wrote:
From: Wayne Chang <waynec@xxxxxxxxxx>

Device-tree uses the 'firmware-name' string property to pass a name of
the firmware build to the Cypress CCGx driver. Add a new ACPI string
property to the NVIDIA GPU I2C driver to align with device-tree so that
we can migrate to using a common property name for both ACPI and
device-tree.

Signed-off-by: Wayne Chang <waynec@xxxxxxxxxx>
Co-developed-by: Jon Hunter <jonathanh@xxxxxxxxxx>
Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx>
Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
---
V8 -> V10: no changes
V7: Added Heikki's reviewed-by
V6: no changes
V5: Added this patch from V3

  drivers/i2c/busses/i2c-nvidia-gpu.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c
index 12e330cd7635..6d81ea530a83 100644
--- a/drivers/i2c/busses/i2c-nvidia-gpu.c
+++ b/drivers/i2c/busses/i2c-nvidia-gpu.c
@@ -261,6 +261,7 @@ MODULE_DEVICE_TABLE(pci, gpu_i2c_ids);
  static const struct property_entry ccgx_props[] = {
  	/* Use FW built for NVIDIA (nv) only */
  	PROPERTY_ENTRY_U16("ccgx,firmware-build", ('n' << 8) | 'v'),
+	PROPERTY_ENTRY_STRING("firmware-name", "nvidia,gpu"),
  	{ }
  };

Apologies, but we appear to be missing you on this series [0]. Please take a look at patches, 2, 3 and 4. If you are OK with the changes, I am not sure if it is easiest for Heikki or Greg to merge?

Thanks
Jon

[0] https://lore.kernel.org/linux-tegra/20230131175748.256423-1-jonathanh@xxxxxxxxxx/

--
nvpublic



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux