On Wed, Feb 1, 2023 at 4:13 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 01/02/2023 16:00, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > > > Add DT bindings for the TLMM controller on sa8775p platforms. > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + > > + tlmm: pinctrl@f000000 { > > + compatible = "qcom,sa8775p-tlmm"; > > + reg = <0xf000000 0x1000000>; > > + interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>; > > + gpio-controller; > > + #gpio-cells = <2>; > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + gpio-ranges = <&tlmm 0 0 149>; > > You have 148 GPIOs, so s/149/148/. > > I'll fix other bindings as we have such mistake in several places. > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Best regards, > Krzysztof > Ah, cr*p, sorry for missing it. Linus - can you change it when applying? I don't want to send more noise. Bart