Hi Krzysztof, On Wed, Feb 1, 2023 at 8:47 AM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 01/02/2023 04:09, kernel test robot wrote: > > Hi Balsam, > > > > Thank you for the patch! Yet something to improve: > > > > > > > > url: https://github.com/intel-lab-lkp/linux/commits/UPDATE-20230131-234122/bchihi-baylibre-com/thermal-drivers-mediatek-Relocate-driver-to-mediatek-folder/20230124-211910 > > base: the 4th patch of https://lore.kernel.org/r/20230124131717.128660-5-bchihi%40baylibre.com > > patch link: https://lore.kernel.org/r/20230131153816.21709-1-bchihi%40baylibre.com > > patch subject: [PATCH v12] thermal: drivers: mediatek: Add the Low Voltage Thermal Sensor driver > > config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20230201/202302011058.17Vvc1pN-lkp@xxxxxxxxx/config) > > compiler: s390-linux-gcc (GCC) 12.1.0 > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # https://github.com/intel-lab-lkp/linux/commit/5646ebf6f10ff0fc60c04d8c57523f7c44526b41 > > git remote add linux-review https://github.com/intel-lab-lkp/linux > > git fetch --no-tags linux-review UPDATE-20230131-234122/bchihi-baylibre-com/thermal-drivers-mediatek-Relocate-driver-to-mediatek-folder/20230124-211910 > > git checkout 5646ebf6f10ff0fc60c04d8c57523f7c44526b41 > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 olddefconfig > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash > > > > If you fix the issue, kindly add following tag where applicable > > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > > > All errors (new ones prefixed by >>): > > > >>> drivers/thermal/mediatek/lvts_thermal.c:20:10: fatal error: dt-bindings/thermal/mediatek,lvts-thermal.h: No such file or directory > > 20 | #include <dt-bindings/thermal/mediatek,lvts-thermal.h> > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > So here is your driver... and you decided not only to make reviewers > life more difficult, but also to fail all automated tools. > > No, that's not how patchsets should be sent. You have here clear > dependency, you cannot send them separately. I'm sorry, I'll be careful next time. I apologize for breaking the series. I will take into account the new change requests in the next full v13 the series. > > Best regards, > Krzysztof > Best regards, Balsam
