Hi Krzysztof, On Wed, Feb 1, 2023 at 2:37 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 01/02/2023 14:34, Balsam CHIHI wrote: > >>> + > >>> +properties: > >>> + compatible: > >>> + enum: > >>> + - mediatek,mt8195-lvts-ap > >>> + - mediatek,mt8195-lvts-mcu > >> > >> What about other devices? You called the file name as generic for all > >> Mediatek SoCs, so why only one SoC is here? Is there going to be more? > >> If yes, why they cannot be added now? > > > > Yes, there is another MTK SoC mt8192 that supports LVTS, > > I was asked in v10 of the series to remove the unimplemented SoC. > > It will be added later with the driver that supports it. > > just let me know if you still want to add mt8192 bindings in the next > > version without the driver. > > The binding should be complete, if that's possible, so if you had mt8192 > already there, it could stay. Anyway it's fine then. OK, I will put back mt8192 dt-bindings. this is the link to the v10 patch "https://patchwork.kernel.org/project/linux-pm/patch/20230112152855.216072-3-bchihi@xxxxxxxxxxxx/";, it will be the same in next version (v13) of series. it would be great if you review it in advance, so I could take into account the new changes if needed. is it possible to resend this patch under v13, to simplify the review and avoid breaking the series again? > > Best regards, > Krzysztof > Best regards, Balsam
