Re: [PATCH 0/8] soc: amlogic: switch bindings to yaml and adjust some dtbs's

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 24.01.2023 08:16, Neil Armstrong wrote:
> Hi Heiner,
> 
> Le 23/01/2023 à 22:22, Heiner Kallweit a écrit :
>> At first adjust some existing dtbs's so that they pass dtbs_check
>> after switching bindings to yaml.
> 
> Thanks for this patchset, but please drop patches 1, 3 & 4, and take
> in account the existing compatible usage in your new bindings like
> I did in my conversion patchset.
> 
> While we did remove some bad compatibles we introduced a few years ago,
> now the GXBB, GXL & GXM are now stable a aew LTS releases now and
> a few other projects uses them as-is (U-Boot, BSDs, ...) so changing
> the compatibles isn't an option anymore... and we can't know which
> one they use and how the implementation behaves we must document
> the existing usage without breaking any potential users (including linux).
> 
I wasn't aware of this. Thanks for the hint.
So I'll rework the schemas to cover current usage of compatible strings.

> Thanks,
> Neil
> 
Heiner
> 
> 
>>
>> Then switch further Amlogic Meson bindings to yaml.
>> Tested with make targets dt_binding_check and dtbs_check.
>>
>> Heiner Kallweit (8):
>>    arm64: dts: meson-gx: Remove invalid pwm compatible
>>    arm64: dts: amlogic: Fix non-compliant SD/SDIO node names
>>    arm64: dts: meson-gx: Set only one compatible string for mmc
>>    arm64: dts: amlogic: Remove invalid compatible string
>>      amlogic,meson-gpio-intc
>>    dt-bindings: rtc: Add Amlogic Meson vrtc controller binding
>>    dt-bindings: pwm: Add Amlogic Meson PWM binding
>>    dt-bindings: interrupt-controller: Add Amlogic Meson GPIO interrupt
>>      controller binding
>>    dt-bindings: pinctrl: Add Amlogic Meson pinctrl binding
>>
>>   .../amlogic,meson-gpio-intc.txt               |  38 ------
>>   .../amlogic,meson-gpio-intc.yaml              |  72 +++++++++++
>>   .../pinctrl/amlogic,meson-pinctrl.yaml        | 121 ++++++++++++++++++
>>   .../bindings/pinctrl/meson,pinctrl.txt        |  94 --------------
>>   .../devicetree/bindings/pwm/pwm-amlogic.yaml  |  61 +++++++++
>>   .../devicetree/bindings/pwm/pwm-meson.txt     |  29 -----
>>   .../bindings/rtc/amlogic,meson-vrtc.yaml      |  50 ++++++++
>>   .../bindings/rtc/rtc-meson-vrtc.txt           |  22 ----
>>   arch/arm64/boot/dts/amlogic/meson-axg.dtsi    |   5 +-
>>   .../boot/dts/amlogic/meson-g12-common.dtsi    |   7 +-
>>   arch/arm64/boot/dts/amlogic/meson-gx.dtsi     |  15 +--
>>   arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi   |   3 +-
>>   arch/arm64/boot/dts/amlogic/meson-gxl.dtsi    |   3 +-
>>   arch/arm64/boot/dts/amlogic/meson-s4.dtsi     |   3 +-
>>   arch/arm64/boot/dts/amlogic/meson-sm1.dtsi    |   3 +-
>>   15 files changed, 320 insertions(+), 206 deletions(-)
>>   delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
>>   create mode 100644 Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.yaml
>>   create mode 100644 Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl.yaml
>>   delete mode 100644 Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt
>>   create mode 100644 Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>>   delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-meson.txt
>>   create mode 100644 Documentation/devicetree/bindings/rtc/amlogic,meson-vrtc.yaml
>>   delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-meson-vrtc.txt
>>
> 
> 




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux