On 21/01/2023 12:06, Johan Jonker wrote: > Currently all Rockchip gpio nodes have the same compatible. > Compatible strings should be SoC related. > > Signed-off-by: Johan Jonker <jbx6244@xxxxxxxxx> > --- > .../bindings/gpio/rockchip,gpio-bank.yaml | 26 ++++++++++++++++--- > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > index affd823c8..a604c3638 100644 > --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > @@ -11,9 +11,27 @@ maintainers: > > properties: > compatible: > - enum: > - - rockchip,gpio-bank > - - rockchip,rk3188-gpio-bank0 > + oneOf: > + - const: rockchip,gpio-bank > + - const: rockchip,rk3188-gpio-bank0 That's an enum so keep them like that > + - items: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
