Hi, the driver looks mostly good. Thank you for your hard work, and also thanks to Andy for his great review efforts again! > +static unsigned int ls2x_i2c_func(struct i2c_adapter *adap) > +{ > + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; > +} Have you tried messages with zero-length or the SMBUS_QUICK transfer which is basically the same? i2cdectect uses it by default, so if that works, then we are good. > +/* The DC subsystem depends on it, we should initialize it earlier. */ > +static int __init ls2x_i2c_init_driver(void) > +{ > + return platform_driver_register(&ls2x_i2c_driver); > +} > +subsys_initcall(ls2x_i2c_init_driver); Can't this be handled with deferred probing? Happy hacking, Wolfram
Attachment:
signature.asc
Description: PGP signature