Re: [PATCH] ARM: dts: qcom: apq8064: add second DSI host and PHY

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 19.01.2023 14:22, Dmitry Baryshkov wrote:
> Add second DSI host and PHY available on the APQ8064 platform.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
>  arch/arm/boot/dts/qcom-apq8064.dtsi | 69 ++++++++++++++++++++++++++++-
>  1 file changed, 67 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index b7e5b45e1c04..3ae6abd85f3d 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -865,8 +865,8 @@ mmcc: clock-controller@4000000 {
>  				 <&gcc PLL8_VOTE>,
>  				 <&dsi0_phy 1>,
>  				 <&dsi0_phy 0>,
> -				 <0>,
> -				 <0>,
> +				 <&dsi1_phy 1>,
> +				 <&dsi1_phy 0>,
>  				 <&hdmi_phy>;
>  			clock-names = "pxo",
>  				      "pll3",
> @@ -1342,6 +1342,71 @@ dsi0_phy: phy@4700200 {
>  			status = "disabled";
>  		};
>  
> +		dsi1: dsi@5800000 {
> +			compatible = "qcom,mdss-dsi-ctrl";
> +			label = "MDSS DSI CTRL->0";
->1 if you really want to add it

but I don't see why it's useful..

> +			#address-cells = <1>;
> +			#size-cells = <0>;
These two don't belong here

> +			interrupts = <GIC_SPI 166 IRQ_TYPE_LEVEL_HIGH>;
> +			reg = <0x05800000 0x200>;
> +			reg-names = "dsi_ctrl";
> +
> +			clocks = <&mmcc DSI2_M_AHB_CLK>,
> +				<&mmcc DSI2_S_AHB_CLK>,
> +				<&mmcc AMP_AHB_CLK>,
> +				<&mmcc DSI2_CLK>,
> +				<&mmcc DSI2_BYTE_CLK>,
> +				<&mmcc DSI2_PIXEL_CLK>,
> +				<&mmcc DSI2_ESC_CLK>;
> +			clock-names = "iface", "bus", "core_mmss",
> +					"src", "byte", "pixel",
> +					"core";
This should be a vertical list

> +
> +			assigned-clocks = <&mmcc DSI2_BYTE_SRC>,
> +					<&mmcc DSI2_ESC_SRC>,
> +					<&mmcc DSI2_SRC>,
> +					<&mmcc DSI2_PIXEL_SRC>;
> +			assigned-clock-parents = <&dsi0_phy 0>,
> +						<&dsi0_phy 0>,
> +						<&dsi0_phy 1>,
> +						<&dsi0_phy 1>;
Bad indentation from clocks to assigned-clock-parents inclusive

> +			syscon-sfpb = <&mmss_sfpb>;
> +			phys = <&dsi1_phy>;
> +			status = "disabled";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +					dsi1_in: endpoint {
> +					};
> +				};
> +
> +				port@1 {
> +					reg = <1>;
> +					dsi1_out: endpoint {
> +					};
> +				};
> +			};
> +		};
> +
> +
> +		dsi1_phy: dsi-phy@5800200 {
> +			compatible = "qcom,dsi-phy-28nm-8960";
> +			#clock-cells = <1>;
> +			#phy-cells = <0>;
These two don't belong here

> +
> +			reg = <0x05800200 0x100>,
> +				<0x05800300 0x200>,
> +				<0x05800500 0x5c>;
Bad indentation


> +			reg-names = "dsi_pll", "dsi_phy", "dsi_phy_regulator";
This should be a vertical list

Konrad
> +			clock-names = "iface", "ref";
> +			clocks = <&mmcc DSI2_M_AHB_CLK>,
> +				 <&pxo_board>;
> +			status = "disabled";
> +		};
>  
>  		mdp_port0: iommu@7500000 {
>  			compatible = "qcom,apq8064-iommu";



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux