On 17/01/2023 17:13, Mario Kicherer wrote: > This patch adds dt-bindings for the NXP MC34VR500 PMIC. > > Signed-off-by: Mario Kicherer <dev@xxxxxxxxxxxx> > --- Except being untested one more comment: > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + mc34vr500@8 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof