On 17/01/2023 11:54, Kelvin Cheung wrote: > Rob Herring <robh@xxxxxxxxxx> 于2023年1月13日周五 23:26写道： >> >> >> On Fri, 13 Jan 2023 19:07:37 +0800, Keguang Zhang wrote: >>> Add devicetree binding document for the Loongson-1 clock driver. >>> >>> Signed-off-by: Keguang Zhang <keguang.zhang@xxxxxxxxx> >>> --- >>> .../bindings/clock/loongson,ls1x-clk.yaml | 81 +++++++++++++++++++ >>> 1 file changed, 81 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/clock/loongson,ls1x-clk.yaml >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> Documentation/devicetree/bindings/clock/loongson,ls1x-clk.example.dts:36.39-41.15: Warning (unique_unit_address_if_enabled): /example-0/clocks/cpu_clk@1fe78034: duplicate unit-address (also used in node /example-0/clocks/ahb_clk@1fe78034) > > I did notice this warning. > But my situation is the cpu_clk and ahb_clk share the same registers. > May I have your suggestion? Don't introduce warnings and errors no matter what. If your code is not correct, don't submit it, but instead try to fix it. You got proper solution - use one clock controller, not devices per each clock. Why Loongson is special here from all other devices in the world? Best regards, Krzysztof
