On 1/16/23 12:34, Frieder Schrempf wrote:
Hi,
Current practice does not match this statement however, notice how they
are all gpio 1 4 :
$ git grep sd-vsel-gpios
Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml:
sd-vsel-gpios:
arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi: sd-vsel-gpios =
<&gpio1 4 GPIO_ACTIVE_HIGH>;
arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts:
sd-vsel-gpios = <&gpio1 4 GPIO_ACTIVE_HIGH>;
arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi: sd-vsel-gpios =
<&gpio1 4 GPIO_ACTIVE_HIGH>;
arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi: sd-vsel-gpios =
<&gpio1 4 GPIO_ACTIVE_HIGH>;
Yes, but these are probably all copy-pasted from somewhere. Maybe from
my original Kontron DT (before [1]) where I was actually using
sd-vsel-gpios.
But these DTs all mux the VSELECT signal to the GPIO1_IO04 pad, so
sd-vsel-gpios is useless.
Maybe we should just scrub them all then ?