Hello Marek,
On 18.12.22 06:18, Marek Vasut wrote:
> Add support for Data Modul i.MX8M Plus eDM SBC board. This is an
> evaluation board for various custom display units. Currently
> supported are serial console, ethernet, eMMC, SD, SPI NOR,
> USB host and USB OTG.
>
> Signed-off-by: Marek Vasut <marex@xxxxxxx>
> ---
> Cc: Denys Drozdov <denys.drozdov@xxxxxxxxxxx>
> Cc: Fabio Estevam <festevam@xxxxxxx>
> Cc: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> Cc: Li Yang <leoyang.li@xxxxxxx>
> Cc: Marcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx>
> Cc: Marek Vasut <marex@xxxxxxx>
> Cc: Matthias Schiffer <matthias.schiffer@xxxxxxxxxxxx>
> Cc: Max Krummenacher <max.krummenacher@xxxxxxxxxxx>
> Cc: NXP Linux Team <linux-imx@xxxxxxx>
> Cc: Peng Fan <peng.fan@xxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: Tim Harvey <tharvey@xxxxxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
Could you share your get_maintainers.pl invocation? I'd like to
adjust the reviewer entry in MAINTAINERS, so such patches get
into our kernel@xxxxxxxxxxxxxx inbox as well.
Some more comments below.
> + pmic: pmic@25 {
> + compatible = "nxp,pca9450c";
> + reg = <0x25>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_pmic>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> + sd-vsel-gpios = <&gpio1 4 GPIO_ACTIVE_HIGH>;
Here you assume GPIO1_IO04 is muxed as GPIO.
> + pinctrl_usdhc2: usdhc2-grp {
> + fsl,pins = <
> + MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT 0xc1
Here you mux it for USDHC2_VSELECT though. Is this intended?
> +/* eMMC */
> +&usdhc3 {
> + pinctrl-names = "default", "state_100mhz", "state_200mhz";
> + pinctrl-0 = <&pinctrl_usdhc3>;
> + pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
> + pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
> + vmmc-supply = <&buck4>;
> + vqmmc-supply = <&buck5>;
> + bus-width = <8>;
> + non-removable;
You can add
no-sd;
no-sdio;
to skip that init dance if the eMMC is indeed non-removable.
Cheers,
Ahmad
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
