On 15/01/2023 18:40, Sahin, Okan wrote: > Hi Krzysztof, > > Thank you for your feedback and efforts. I apologize for some missing points of v2 patch. I tried to do my best. I will be more careful to fix all feedback before sending new patch so I want to ask a few things before sending v3 patch Please wrap lines in your email. (...) >>> + >>> + adc: >>> + type: object >>> + additionalProperties: false >>> + properties: >>> + compatible: >>> + const: adi,max77541-adc >> >> This is a friendly reminder during the review process. >> >> It seems my previous comments were not fully addressed. Maybe my feedback >> got lost between the quotes, maybe you just forgot to apply it. >> Please go back to the previous discussion and either implement all requested >> changes or keep discussing them. >> >> Thank you. > Honestly, I don't quite understand what you're suggesting regarding the adc part. I thought I should add the adc as an object since it is in the mfd device. Do I need to remove this part? What is unclear in my comment from v1? Yes, you need to remove it because it useless. There is no need for a node consisting of only compatible. Your driver does not need the DT node at all to do its job. Best regards, Krzysztof
