Hi Krzysztof, Thank you for your feedback and efforts. I also have a few question below. On Tue, 27 Dec 2022 10:57 AM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 26/12/2022 23:38, Okan Sahin wrote: > > The bindings for MAX77541 and MAX77540 regulator drivers. > > 1. Again: > https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v5.17.1/source/D > ocumentation/process/submitting- > patches.rst*L95__;Iw!!A3Ni8CS0y2Y!7nAM0w0tZiMzaqSFijTSs6_FiIcbPVz- > n0BajxVC1WDh0GfsgL7XoVFoFToHza-Cy2_p8o0UEEc82BOnwgesjPcas_9m$ > > 2. Please wrap commit message according to Linux coding style / submission > process (neither too early nor over the limit): > https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v5.18- > rc4/source/Documentation/process/submitting- > patches.rst*L586__;Iw!!A3Ni8CS0y2Y!7nAM0w0tZiMzaqSFijTSs6_FiIcbPVz- > n0BajxVC1WDh0GfsgL7XoVFoFToHza-Cy2_p8o0UEEc82BOnwgesjE6sDUk6$ > > 3. Subject: drop second, redundant "bindings". > > I will update like you suggest. Is there any command that you can advise to check format of commit is suitable or not by using check_patch? I just added checkpatch into .git/hooks/post-commit file. > > > > Signed-off-by: Okan Sahin <okan.sahin@xxxxxxxxxx> > > --- > > .../regulator/adi,max77541-regulator.yaml | 44 +++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 45 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/regulator/adi,max77541-regulator.yam > > l > > > > diff --git > > a/Documentation/devicetree/bindings/regulator/adi,max77541-regulator.y > > aml > > b/Documentation/devicetree/bindings/regulator/adi,max77541-regulator.y > > aml > > new file mode 100644 > > index 000000000000..67d48bfcb627 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/regulator/adi,max77541-regulat > > +++ or.yaml > > @@ -0,0 +1,44 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 > > +--- > > +$id: > > +https://urldefense.com/v3/__http://devicetree.org/schemas/regulator/a > > +di,max77541- > regulator.yaml*__;Iw!!A3Ni8CS0y2Y!7nAM0w0tZiMzaqSFijTSs6_ > > +FiIcbPVz-n0BajxVC1WDh0GfsgL7XoVFoFToHza- > Cy2_p8o0UEEc82BOnwgesjKsOQbIb > > +$ > > +$schema: > > +https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.y > > +aml*__;Iw!!A3Ni8CS0y2Y!7nAM0w0tZiMzaqSFijTSs6_FiIcbPVz- > n0BajxVC1WDh0G > > +fsgL7XoVFoFToHza-Cy2_p8o0UEEc82BOnwgesjEgbPQFe$ > > + > > +title: Buck Converter for MAX77540/MAX77541 > > + > > +maintainers: > > + - Okan Sahin <okan.sahin@xxxxxxxxxx> > > + > > +description: | > > + This is a part of device tree bindings for ADI MAX77540/MAX77541 > > + > > + The buck converter is represented as a sub-node of the PMIC node on the > device tree. > > + > > + The device has two buck regulators. > > + See also Documentation/devicetree/bindings/mfd/adi,max77541.yaml > > + for additional information and example. > > + > > +properties: > > + compatible: > > + enum: > > + - adi,max77540-regulator > > + - adi,max77541-regulator > > + > > +patternProperties: > > + "^BUCK[12]$": > > Old DT example was correct - lowercase node names. Actually, I did not change this part of the patch. I checked other examples, and it looks like using upper case under regulators node seems correct to me. Additionally, there is no warning or error after "make dt_binding_check". > > Best regards, > Krzysztof Best regards, Okan
