On 11/01/2023 01:59, William Zhang wrote: >>>> You need to add constraints for reg-names, same way as for reg. >>>> Disallowing the reg-names also could work, but there won't be benefit in >>>> it. Better to have uniform DTS. >>>> >>> I agree it is better to have the uniform DTS but the situation here is >>> that the brcm,bcm6328-hsspi does not require reg name since there is >>> only one register needed and it was already used in many chip dts for >>> long time. If I enforce it to have the corresponding reg name, that >> >> No one told you to enforce to have a reg-names. >> >>> could potentially break the compatibility of those old device if the >>> driver change to use reg name, right? >> >> How compatibility is broken by some optional, unrelated property? >> > I think I misunderstand what you said. You basically want the reg-name > minItem/maxItem constraints for brcm,bcm6328-hsspi compatible as well so > it is consistent for all the compatibles? Yes. Best regards, Krzysztof
