Hi Marek, On Tue, Jan 3, 2023 at 12:04 AM Marek Vasut <marex@xxxxxxx> wrote: > > On 1/1/23 18:57, Dario Binacchi wrote: > > The idea for this series was born back from Dublin (ELCE 2022) after > > having attended the talk entitled "Updating and Modernizing Clock > > Drivers" held by Chen-Yu Tsai and the availability of a board with > > imx8mn SOC. > > > > This series aims to setup all imx8mn's clocks from the device tree and > > remove the legacy setup code with hardwired parameters. > > > > I am well aware that the series lacks patches for the DT bindings. The > > effort up to this point has been important and so I thought I'd ask for > > feedback from the community before proceeding to implement them. If it > > is positive I will add the DT binding patches starting from version 2. > > > > The series has been tested on the BSH SystemMaster (SMM) S2 board: > > https://www.apertis.org/reference_hardware/imx8mn_bsh_smm_s2pro_setup > > I might be wrong, but I vaguely recall AT91 (?) had this kind of massive > clock tree description in DT and they then switched to much simpler > clock description where the clock topology is encoded in the driver > instead (like what iMX does right now). It might be worth having a look > at that and the reasoning around that conversion. I took inspiration from Tero Kristo's work on the clock subsystem for TI platforms. I think he did a great job in both device tree definition and driver implementation. IMHO, this way the drivers are more flexible and the code can be more easily re-used on more platforms. Thanks and regards, Dario -- Dario Binacchi Senior Embedded Linux Developer dario.binacchi@xxxxxxxxxxxxxxxxxxxx __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@xxxxxxxxxxxxxxxxxxxx www.amarulasolutions.com
