On Thu, Dec 29, 2022 at 11:38:04PM +0000, Bryan O'Donoghue wrote: > On 29/12/2022 21:41, Stephan Gerhold wrote: > > That is still good enough to replace qcom,dp-manual-pullup though. > > But there's no requirement to tie USB_IN_x high if VBUS is not connected to > it. > I've yet to find any device where USB_IN is not connected in a usable way. But as I said I leave it up to you - it would be nice to have a proper solution for devices where VBUS state cannot be determined at all. Those devices should be rare though so if &pm8916_usbin works in your case maybe the time would be better invested into other open problems right now. :) Thanks, Stephan