On 19/12/2022 09:52, Bough Chen wrote: >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> Sent: 2022年12月15日 18:12 >> To: Bough Chen <haibo.chen@xxxxxxx>; jic23@xxxxxxxxxx; lars@xxxxxxxxxx; >> robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; >> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx >> Cc: festevam@xxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; >> linux-iio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; >> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx >> Subject: Re: [PATCH v2 2/3] dt-bindings: iio: adc: Add binding documentation for >> NXP IMX93 ADC >> >> On 14/12/2022 14:35, haibo.chen@xxxxxxx wrote: >>> From: Haibo Chen <haibo.chen@xxxxxxx> >>> >>> The IMX93 SoC has a new ADC IP, so add binding documentation for NXP >>> IMX93 ADC. >>> >>> Signed-off-by: Haibo Chen <haibo.chen@xxxxxxx> >>> --- >>> .../bindings/iio/adc/nxp,imx93-adc.yaml | 79 >> +++++++++++++++++++ >>> 1 file changed, 79 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml >>> >>> diff --git >>> a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml >>> b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml >>> new file mode 100644 >>> index 000000000000..229bb79e255c >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml >> >> This was already sent, so I am surprised to see this in worse or the same state. >> Don't force us to repeat review, it's a waste of time. > > Sorry, I'm focus on the driver side, will pay much attention on the yaml binding. > > By the way, for your first review comments: > > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + const: ipg > > No need for clock-names in such case. I think this was for the other patch and recommendation was to drop entire clock-names. Here you do not have it, so no need to change this. Best regards, Krzysztof
