> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: 2022年12月15日 18:12
> To: Bough Chen <haibo.chen@xxxxxxx>; jic23@xxxxxxxxxx; lars@xxxxxxxxxx;
> robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx
> Cc: festevam@xxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>;
> linux-iio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 2/3] dt-bindings: iio: adc: Add binding documentation for
> NXP IMX93 ADC
>
> On 14/12/2022 14:35, haibo.chen@xxxxxxx wrote:
> > From: Haibo Chen <haibo.chen@xxxxxxx>
> >
> > The IMX93 SoC has a new ADC IP, so add binding documentation for NXP
> > IMX93 ADC.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@xxxxxxx>
> > ---
> > .../bindings/iio/adc/nxp,imx93-adc.yaml | 79
> +++++++++++++++++++
> > 1 file changed, 79 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> > new file mode 100644
> > index 000000000000..229bb79e255c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
>
> This was already sent, so I am surprised to see this in worse or the same state.
> Don't force us to repeat review, it's a waste of time.
Sorry, I'm focus on the driver side, will pay much attention on the yaml binding.
By the way, for your first review comments:
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + const: ipg
No need for clock-names in such case.
How should I handle this case here? I search in this directory(iio/adc), and find many other yaml also write this way.
Do you mean change like this:
clock-names: true
If you will, can you help tell where is the yaml guide, I'm not familiar with yaml rule.
Best Regards
Haibo Chen
>
> > @@ -0,0 +1,79 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fschemas%2Fiio%2Fadc%2Fnxp%2Cimx93-adc.yaml%23&da
> ta=0
> >
> +5%7C01%7Chaibo.chen%40nxp.com%7C0f5dbde6e91b4c8f920c08dade84c2b4
> %7C68
> >
> +6ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638066959030689942%7C
> Unknown
> >
> +%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haW
> wiLC
> >
> +JXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=iG7kL12EZ17jqPyLPx8X79
> m8Muzaul
> > +CZDuqAl8Ayhdw%3D&reserved=0
> > +$schema:
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Chaib
> o.che
> >
> +n%40nxp.com%7C0f5dbde6e91b4c8f920c08dade84c2b4%7C686ea1d3bc2b4c
> 6fa92c
> >
> +d99c5c301635%7C0%7C0%7C638066959030689942%7CUnknown%7CTWFpb
> GZsb3d8eyJ
> >
> +WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7
> C300
> >
> +0%7C%7C%7C&sdata=fXkafmq9%2FLxo2I%2FyIFRcTgwVMLP7yBXYDPrn0
> DJzuV4%
> > +3D&reserved=0
> > +
> > +title: NXP iMX93 ADC bindings
>
> Drop bindings. How did it appear here? It wasn't in v1.
>
> > +
> > +maintainers:
> > + - Haibo Chen <haibo.chen@xxxxxxx>
> > +
> > +description:
> > + The ADC on iMX93 is a 8-channel 12-bit 1MS/s ADC with 4 channels
> > + connected to pins. it support normal and inject mode, include
> > + One-Shot and Scan (continuous) conversions. Programmable DMA
> > + enables for each channel Also this ADC contain alternate analog
> > + watchdog thresholds, select threshold through input ports. And
> > + also has Self-test logic and Software-initiated calibration.
> > +
> > +properties:
> > + compatible:
> > + const: nxp,imx93-adc
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + description:
> > + line 0 for WDGnL (watchdog threshold) interrupt requests.
> > + line 1 for WDGnH (watchdog threshold) interrupt requests.
> > + line 2 for normal conversion, include EOC (End of Conversion)
> > + interrupt request, ECH (End of Chain) interrupt request,
> > + JEOC (End of Injected Conversion mode) interrupt request
> > + and JECH (End of injected Chain) interrupt request.
> > + line 3 for Self-testing Interrupts.
> > + maxItems: 4
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + vref-supply:
> > + description:
> > + The reference voltage which used to establish channel scaling.
> > +
> > + "#io-channel-cells":
> > + const: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - clocks
> > + - clock-names
> > + - vref-supply
> > + - "#io-channel-cells"
> > +
> > +additionalProperties: false
> > +
>
> Best regards,
> Krzysztof
