On Thu, Dec 15, 2022 at 05:49:57PM +0000, Russell King (Oracle) wrote:
> Hi,
>
> On Thu, Dec 15, 2022 at 12:54:37AM +0100, Christian Marangi wrote:
> > +static int
> > +qca8k_cled_hw_control_configure(struct led_classdev *ldev, unsigned long rules,
> > + enum blink_mode_cmd cmd)
> > +{
> > + struct qca8k_led *led = container_of(ldev, struct qca8k_led, cdev);
> > + struct led_trigger *trigger = ldev->trigger;
> > + struct qca8k_led_pattern_en reg_info;
> > + struct qca8k_priv *priv = led->priv;
> > + u32 offload_trigger = 0, mask, val;
> > + int ret;
> > +
> > + /* Check trigger compatibility */
> > + if (strcmp(trigger->name, "netdev"))
> > + return -EOPNOTSUPP;
> > +
> > + if (!strcmp(trigger->name, "netdev"))
> > + ret = qca8k_parse_netdev(rules, &offload_trigger, &mask);
>
> I'm not sure how well the compiler will spot that, but as far as
> readability goes, that second if() statement appears to be redundant.
>
Leftover when the driver supported 2 trigger. The idea was to provide a
"template" to show the flow of the function.
> > +
> > + if (ret)
> > + return ret;
> > +
> > + qca8k_get_control_led_reg(led->port_num, led->led_num, ®_info);
> > +
> > + switch (cmd) {
> > + case BLINK_MODE_SUPPORTED:
> > + /* We reach this point, we are sure the trigger is supported */
> > + return 1;
> > + case BLINK_MODE_ZERO:
> > + /* We set 4hz by default */
> > + u32 default_reg = QCA8K_LED_BLINK_4HZ;
> > +
> > + ret = regmap_update_bits(priv->regmap, reg_info.reg,
> > + QCA8K_LED_RULE_MASK << reg_info.shift,
> > + default_reg << reg_info.shift);
> > + break;
> > + case BLINK_MODE_ENABLE:
> > + ret = regmap_update_bits(priv->regmap, reg_info.reg,
> > + mask << reg_info.shift,
> > + offload_trigger << reg_info.shift);
> > + break;
> > + case BLINK_MODE_DISABLE:
> > + ret = regmap_update_bits(priv->regmap, reg_info.reg,
> > + mask << reg_info.shift,
> > + 0);
> > + break;
>
> I think it needs to be made more clear in the documentation that if
> this is called with ENABLE, then _only_ those modes in flags... (or
> is it now called "rules"?) are to be enabled and all other modes
> should be disabled. Conversely, DISABLE is used to disable all
> modes. However, if that's the case, then ZERO was misdescribed, and
> should probably be called DEFAULT. At least that's the impression
> that I get from the above code.
>
ZERO disable all the rules. Driver can keep some rule enabled (this is
the case for qca8k blink mode at 4hz by default)
ENABLE/DISABLE only act on the provided thing in rules. In the current
imlementation parse rules, generate a mask and update the values
accordingly. Other rules are not touched. This is based on the fact that
the first and the last thing done is calling ZERO to reset all the rules
to a known state.
I will try to improve the Documentation on this aspect.
Hope you know understand better the calling flow.
> > + case BLINK_MODE_READ:
> > + ret = regmap_read(priv->regmap, reg_info.reg, &val);
> > + if (ret)
> > + return ret;
> > +
> > + val >>= reg_info.shift;
> > + val &= offload_trigger;
> > +
> > + /* Special handling for LED_BLINK_2HZ */
> > + if (!val && offload_trigger == QCA8K_LED_BLINK_2HZ)
> > + val = 1;
>
> Hmm, so if a number of different modes is in flags or rules, then
> as long as one matches, this returns 1? So it's an "any of these
> modes is enabled" test.
>
Ok this should be changed and you are right. READ should return true or
false if the rule (or rules) are enabled. This work for a single rule
but doesn't if multiple rules are provided.
Will fix that since this is wrong.
> > +
> > + return val;
> > + default:
> > + return -EOPNOTSUPP;
> > + }
> > +
> > + return ret;
> > +}
> > +
> > +static void
> > +qca8k_led_brightness_set(struct qca8k_led *led,
> > + enum led_brightness b)
> > +{
> > + struct qca8k_led_pattern_en reg_info;
> > + struct qca8k_priv *priv = led->priv;
> > + u32 val = QCA8K_LED_ALWAYS_OFF;
> > +
> > + qca8k_get_enable_led_reg(led->port_num, led->led_num, ®_info);
> > +
> > + if (b)
> > + val = QCA8K_LED_ALWAYS_ON;
> > +
> > + regmap_update_bits(priv->regmap, reg_info.reg,
> > + GENMASK(1, 0) << reg_info.shift,
> > + val << reg_info.shift);
> > +}
> > +
> > +static void
> > +qca8k_cled_brightness_set(struct led_classdev *ldev,
> > + enum led_brightness b)
> > +{
> > + struct qca8k_led *led = container_of(ldev, struct qca8k_led, cdev);
> > +
> > + return qca8k_led_brightness_set(led, b);
> > +}
> > +
> > +static enum led_brightness
> > +qca8k_led_brightness_get(struct qca8k_led *led)
> > +{
> > + struct qca8k_led_pattern_en reg_info;
> > + struct qca8k_priv *priv = led->priv;
> > + u32 val;
> > + int ret;
> > +
> > + qca8k_get_enable_led_reg(led->port_num, led->led_num, ®_info);
> > +
> > + ret = regmap_read(priv->regmap, reg_info.reg, &val);
> > + if (ret)
> > + return 0;
> > +
> > + val >>= reg_info.shift;
> > + val &= GENMASK(1, 0);
> > +
> > + return val > 0 ? 1 : 0;
> > +}
> > +
> > +static enum led_brightness
> > +qca8k_cled_brightness_get(struct led_classdev *ldev)
> > +{
> > + struct qca8k_led *led = container_of(ldev, struct qca8k_led, cdev);
> > +
> > + return qca8k_led_brightness_get(led);
> > +}
> > +
> > +static int
> > +qca8k_cled_blink_set(struct led_classdev *ldev,
> > + unsigned long *delay_on,
> > + unsigned long *delay_off)
> > +{
> > + struct qca8k_led *led = container_of(ldev, struct qca8k_led, cdev);
> > + struct qca8k_led_pattern_en reg_info;
> > + struct qca8k_priv *priv = led->priv;
> > +
> > + if (*delay_on == 0 && *delay_off == 0) {
> > + *delay_on = 125;
> > + *delay_off = 125;
> > + }
> > +
> > + if (*delay_on != 125 || *delay_off != 125) {
> > + /* The hardware only supports blinking at 4Hz. Fall back
> > + * to software implementation in other cases.
> > + */
> > + return -EINVAL;
> > + }
> > +
> > + qca8k_get_enable_led_reg(led->port_num, led->led_num, ®_info);
> > +
> > + regmap_update_bits(priv->regmap, reg_info.reg,
> > + GENMASK(1, 0) << reg_info.shift,
> > + QCA8K_LED_ALWAYS_BLINK_4HZ << reg_info.shift);
> > +
> > + return 0;
> > +}
> > +
> > +static int
> > +qca8k_cled_trigger_offload(struct led_classdev *ldev, bool enable)
> > +{
> > + struct qca8k_led *led = container_of(ldev, struct qca8k_led, cdev);
> > +
> > + struct qca8k_led_pattern_en reg_info;
> > + struct qca8k_priv *priv = led->priv;
> > + u32 val = QCA8K_LED_ALWAYS_OFF;
> > +
> > + qca8k_get_enable_led_reg(led->port_num, led->led_num, ®_info);
> > +
> > + if (enable)
> > + val = QCA8K_LED_RULE_CONTROLLED;
> > +
> > + return regmap_update_bits(priv->regmap, reg_info.reg,
> > + GENMASK(1, 0) << reg_info.shift,
> > + val << reg_info.shift);
>
> 88e151x doesn't have the ability to change in this way - we have
> a register with a 4-bit field which selects the LED mode from one
> of many, or forces the LED on/off/hi-z/blink.
>
> Not specifically for this patch, but talking generally about this
> approach, the other issue I forsee with this is that yes, 88e151x has
> three LEDs, but the LED modes are also used to implement control
> signals (e.g., on a SFP, LOS can be implemented by programming mode
> 0 on LED2 (which makes it indicate link or not.) If we expose all the
> LEDs we run the risk of the LED subsystem trampling over that
> configuration and essentially messing up such modules. So the Marvell
> PHY driver would need to know when it is appropriate to expose these
> things to the LED subsystem.
>
> I guess doing it dependent on firmware description as you do in
> this driver would work - if there's no firmware description, they're
> not exposed.
>
The idea is to provide a way to tell the driver what should be done and
tell the trigger that something is not doable and to revert to sw mode.
keeping the thing as simple and direct as possible and leave the rest to
the driver by doing minimal validation on the trigger side.
Do you have suggestion on how this can be improved even more and be more
flexible?
--
Ansuel
