On 2022-12-11 21:07:47, Krzysztof Kozlowski wrote: > On 10/12/2022 18:05, Marijn Suijten wrote: > > [..] > > Just like -state and -pins suffix, sometimes even the unnecessary > > -pins-pins suffix? To me that is the same kind of churn, and *it is > > You compare now to node names. The node names have visible impact (name > of devices in sysfs and in system), is affected by DT schema (is parsed) > and should follow DT spec rules. > > There is nothing like that about labels, therefore they do not have the > same rules or importance. > > I understand that consistency in labels might be good thing... but also > it does not matter. The labels really do not matter, except the code > readability. pmgpio or pmgpios is basically the same readable. For me the latter is more readable, and not only catering to userspace/sysfs but also to the developer reading/writing these DTs is a good thing (where it doesn't affect userspace nor sysfs, like this patch). - Marijn