On Tue, Dec 13, 2022 at 07:12:10PM +0530, Jishnu Prakash wrote: > Hi Greg Hi, please do not top-post :( > These are two SPMI drivers without remove callbacks defined: > > drivers/mfd/qcom-spmi-pmic.c > drivers/mfd/hi6421-spmi-pmic.c Great, they should be fixed up now, right? > We made this change after noticing an issue internally with the first one > above, there was a crash when trying to remove it with rmmod, which is fixed > by this change. Then please say that in the changelog text, otherwise we have no idea _why_ this is needed. All you said was "add this new check _IF_" and we have no idea what the answer to "if" is :( thanks, greg k-h
