On 2022/12/13 15:33, Shawn Lin wrote: > Hi > > On 2022/12/13 15:21, William Qiu wrote: >> >> >> On 2022/12/13 10:24, Shawn Lin wrote: >>> Hi >> >>> use ".common_caps = MMC_CAP_CMD23" instead. >>> >> >> Hi Shawn, >> >> Thank you for taking time to review. >> The .common_caps is not defined in dw_mci_drv_data. >> And .num_caps is also used in dw_mci-rockchip.c. >> > > That means your patch is based on old upstream kernel which hasn't > been updated for at least one year.:) > Sorry about that. I just check the code on 5.15. I will update it in next version. Thank you any way. >> Best regards, >> William Qiu >>>> + .set_ios = dw_mci_starfive_set_ios, >>>> + .parse_dt = dw_mci_starfive_parse_dt, >>>> + .execute_tuning = dw_mci_starfive_execute_tuning, >>>> +}; >>>> + >>>> +static const struct of_device_id dw_mci_starfive_match[] = { >>>