On 2022/12/13 10:24, Shawn Lin wrote:
> Hi
>
> On 2022/12/7 21:17, William Qiu wrote:
>> Add sdio/emmc driver support for StarFive JH7110 soc.
>>
>> Signed-off-by: William Qiu <william.qiu@xxxxxxxxxxxxxxxx>
>> ---
>> MAINTAINERS | 6 +
>> drivers/mmc/host/Kconfig | 10 ++
>> drivers/mmc/host/Makefile | 1 +
>> drivers/mmc/host/dw_mmc-starfive.c | 197 +++++++++++++++++++++++++++++
>> 4 files changed, 214 insertions(+)
>> create mode 100644 drivers/mmc/host/dw_mmc-starfive.c
>>
>
> ...
>
>> +
>> +static unsigned long dw_mci_starfive_caps[] = {
>> + MMC_CAP_CMD23,
>> + MMC_CAP_CMD23,
>> + MMC_CAP_CMD23
>> +};
>> +
>
> ....
>
>> + host->priv = priv;
>> +
>> + return 0;
>> +}
>> +
>> +static const struct dw_mci_drv_data starfive_data = {
>> + .caps = dw_mci_starfive_caps,
>> + .num_caps = ARRAY_SIZE(dw_mci_starfive_caps),
>
> use ".common_caps = MMC_CAP_CMD23" instead.
>
Hi Shawn,
Thank you for taking time to review.
The .common_caps is not defined in dw_mci_drv_data.
And .num_caps is also used in dw_mci-rockchip.c.
Best regards,
William Qiu
>> + .set_ios = dw_mci_starfive_set_ios,
>> + .parse_dt = dw_mci_starfive_parse_dt,
>> + .execute_tuning = dw_mci_starfive_execute_tuning,
>> +};
>> +
>> +static const struct of_device_id dw_mci_starfive_match[] = {
>
