Re: [PATCH v2 06/15] thermal/drivers/tsens: Sort out msm8976 vs msm8956 data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 04/12/22 06:59, Dmitry Baryshkov ha scritto:
Tsens driver mentions that msm8976 data should be used for both msm8976
and msm8956 SoCs. This is not quite correct, as according to the
vendor kernels, msm8976 should use standard slope values (3200), while
msm8956 really uses the slope values found in the driver.

Add separate compatibility string for msm8956, move slope value
overrides to the corresponding init function and use the standard
compute_intercept_slope() function for both platforms.

Fixes: 0e580290170d ("thermal: qcom: tsens-v1: Add support for MSM8956 and MSM8976")
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---
  drivers/thermal/qcom/tsens-v1.c | 56 ++++++++++++++++++---------------
  drivers/thermal/qcom/tsens.c    |  3 ++
  drivers/thermal/qcom/tsens.h    |  2 +-
  3 files changed, 34 insertions(+), 27 deletions(-)


..snip..

@@ -357,6 +333,22 @@ static const struct reg_field tsens_v1_regfields[MAX_REGFIELDS] = {
  	[TRDY] = REG_FIELD(TM_TRDY_OFF, 0, 0),
  };
+int __init init_8956(struct tsens_priv *priv) {

That function should be static as it's both defined and used only in here,
plus, brace goes on a new line. Please fix.

static int __init init_8956(struct tsens_priv *priv)
{


....after which....
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

Cheers,
Angelo



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux