On 01/12/2022 23:56, Dmitry Rokosov wrote: > From: Jian Hu <jian.hu@xxxxxxxxxxx> > > Add the documentation to support Amlogic A1 PLL clock driver, > and add A1 PLL clock controller bindings. > > Signed-off-by: Jian Hu <jian.hu@xxxxxxxxxxx> > Signed-off-by: Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxx> > --- > .../bindings/clock/amlogic,a1-pll-clkc.yaml | 52 +++++++++++++++++++ > include/dt-bindings/clock/a1-pll-clkc.h | 16 ++++++ > 2 files changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml > create mode 100644 include/dt-bindings/clock/a1-pll-clkc.h > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml > new file mode 100644 > index 000000000000..d67250fbeece > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/amlogic,a1-pll-clkc.yaml#"; > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; Drop quotes from both. > + > +title: Amlogic Meson A/C serials PLL Clock Control Unit Device Tree Bindings Drop "Device Tree Bindings" > + > +maintainers: > + - Neil Armstrong <narmstrong@xxxxxxxxxxxx> Not correct email address. > + - Jerome Brunet <jbrunet@xxxxxxxxxxxx> > + - Jian Hu <jian.hu@xxxxxxxxxxx> > + > +properties: > + compatible: > + const: amlogic,a1-pll-clkc > + > + "#clock-cells": > + const: 1 > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: input xtal_fixpll > + - description: input xtal_hifipll As pointed already - this patch cannot work and must not be merged. > + > + clock-names: > + items: > + - const: xtal_fixpll > + - const: xtal_hifipll > + > +required: > + - compatible > + - "#clock-cells" > + - reg > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + clkc_pll: pll-clock-controller@7c80 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "amlogic,a1-pll-clkc"; Use 4 spaces for example indentation. > + reg = <0 0x7c80 0 0x18c>; > + #clock-cells = <1>; > + clocks = <&clkc_periphs 1>, > + <&clkc_periphs 4>; > + clock-names = "xtal_fixpll", "xtal_hifipll"; > + }; > diff --git a/include/dt-bindings/clock/a1-pll-clkc.h b/include/dt-bindings/clock/a1-pll-clkc.h > new file mode 100644 > index 000000000000..58eae237e503 > --- /dev/null > +++ b/include/dt-bindings/clock/a1-pll-clkc.h Filename matching compatible / bindings file. > @@ -0,0 +1,16 @@ Best regards, Krzysztof
