On 01/12/2022 23:57, Dmitry Rokosov wrote: > During running dtbs_check and dt_binding_check checkers the following > problems were found and resolved: > - $id is not correct, it has wrong url path > - no base offset in the dt node definition > - CLKIDs aren't applied by names, just magic int constants there > - address and size cells are required for long reg definition > - wrong indentations > > Signed-off-by: Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxx> > --- > .../bindings/clock/amlogic,a1-clkc.yaml | 36 +++++++++++-------- > 1 file changed, 22 insertions(+), 14 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml > index 7729850046cf..b0249ab21466 100644 > --- a/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml > +++ b/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml > @@ -1,7 +1,7 @@ > -#SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > %YAML 1.2 > --- > -$id: "http://devicetree.org/schemas/amlogic,a1-clkc.yaml#"; > +$id: "http://devicetree.org/schemas/clock/amlogic,a1-clkc.yaml#"; > $schema: "http://devicetree.org/meta-schemas/core.yaml#"; > NAK. This must be squashed. Best regards, Krzysztof
