On Thu, Dec 01, 2022 at 10:10:04PM -0600, Rob Herring wrote: > > On Fri, 02 Dec 2022 01:56:55 +0300, Dmitry Rokosov wrote: > > From: Jian Hu <jian.hu@xxxxxxxxxxx> > > > > Add the documentation to support Amlogic A1 peripheral clock driver, > > and add A1 peripheral clock controller bindings. > > > > Signed-off-by: Jian Hu <jian.hu@xxxxxxxxxxx> > > Signed-off-by: Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxx> > > --- > > .../bindings/clock/amlogic,a1-clkc.yaml | 65 ++++++++++++ > > include/dt-bindings/clock/a1-clkc.h | 98 +++++++++++++++++++ > > 2 files changed, 163 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml > > create mode 100644 include/dt-bindings/clock/a1-clkc.h > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > ./Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml: $id: relative path/filename doesn't match actual path or filename > expected: http://devicetree.org/schemas/clock/amlogic,a1-clkc.yaml# > Documentation/devicetree/bindings/clock/amlogic,a1-clkc.example.dts:18.48-30.11: Warning (unit_address_vs_reg): /example-0/periphs-clock-controller: node has a reg or ranges property, but no unit name > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.example.dtb: periphs-clock-controller: reg: [[0, 2048], [0, 260]] is too long > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221201225703.6507-4-ddrokosov@xxxxxxxxxxxxxx > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > That's totally right warnings and errors. All of them are fixed in the my "fixup" patch of Jian's original dt_binding schema: https://lore.kernel.org/linux-amlogic/20221201225703.6507-11-ddrokosov@xxxxxxxxxxxxxx/ -- Thank you, Dmitry
