On 02/12/2022 08:16, yanhong wang wrote: > > > On 2022/12/2 1:35, Conor Dooley wrote: >> On Thu, Dec 01, 2022 at 05:21:04PM +0100, Krzysztof Kozlowski wrote: >>> On 01/12/2022 10:02, Yanhong Wang wrote: >>>> Add bindings for the StarFive dwmac module on the StarFive RISC-V SoCs. >>> >>> Subject: drop second, redundant "bindings". >>> >>>> >>>> Signed-off-by: Yanhong Wang <yanhong.wang@xxxxxxxxxxxxxxxx> >>>> --- >>>> .../devicetree/bindings/net/snps,dwmac.yaml | 1 + >>>> +properties: >>>> + compatible: >>>> + oneOf: >>> >>> Drop oneOf. You do not have more cases here. >>> >>>> + - items: >>>> + - enum: >>>> + - starfive,dwmac >>> >>> Wrong indentation.... kind of expected since you did not test the bindings. >>> >>>> + - const: snps,dwmac-5.20 >> >> Disclaimer: no familiarity with the version info with DW stuff >> >> Is it a bit foolish to call this binding "starfive,dwmac"? Could there >> not be another StarFive SoC in the future that uses another DW mac IP >> version & this would be better off as "starfive,jh7110-dwmac" or similar? >> > > The StarFive JH8100 SoC in the future that uses the same mac IP version, so call this binding "starfive,dwmac". It's not a reason to make compatible generic. Best regards, Krzysztof
