On 01/12/2022 10:02, Yanhong Wang wrote: > Add bindings for the StarFive dwmac module on the StarFive RISC-V SoCs. Subject: drop second, redundant "bindings". > > Signed-off-by: Yanhong Wang <yanhong.wang@xxxxxxxxxxxxxxxx> > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 1 + > .../bindings/net/starfive,dwmac-plat.yaml | 106 ++++++++++++++++++ > MAINTAINERS | 5 + > 3 files changed, 112 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/starfive,dwmac-plat.yaml > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index d8779d3de3d6..13c5928d7170 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -33,6 +33,7 @@ select: > - snps,dwmac-5.20 > - snps,dwxgmac > - snps,dwxgmac-2.10 > + - starfive,dwmac > > # Deprecated > - st,spear600-gmac > diff --git a/Documentation/devicetree/bindings/net/starfive,dwmac-plat.yaml b/Documentation/devicetree/bindings/net/starfive,dwmac-plat.yaml > new file mode 100644 > index 000000000000..561cf2a713ab > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/starfive,dwmac-plat.yaml Filename should base on compatible. > @@ -0,0 +1,106 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2022 StarFive Technology Co., Ltd. > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/net/dwmac-starfive.yaml#"; Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; Drop quotes from both lines. > + > +title: StarFive DWMAC glue layer > + > +maintainers: > + - Yanhong Wang <yanhong.wang@xxxxxxxxxxxxxxxx> > + > +select: > + properties: > + compatible: > + contains: > + enum: > + - starfive,dwmac > + required: > + - compatible > + > +allOf: > + - $ref: "snps,dwmac.yaml#" Drop quotes. > + > +properties: > + compatible: > + oneOf: Drop oneOf. You do not have more cases here. > + - items: > + - enum: > + - starfive,dwmac Wrong indentation.... kind of expected since you did not test the bindings. > + - const: snps,dwmac-5.20 > + > + clocks: > + items: > + - description: GMAC main clock > + - description: GMAC AHB clock > + - description: PTP clock > + - description: TX clock > + - description: GTXC clock > + - description: GTX clock > + > + clock-names: > + contains: > + enum: > + - stmmaceth > + - pclk > + - ptp_ref > + - tx > + - gtxc > + - gtx Names should be specific and with fixed order, just like clocks are. > + > +required: > + - compatible > + - clocks > + - clock-names > + - resets > + - reset-names > + > +unevaluatedProperties: false > + Best regards, Krzysztof
