On 01/12/22 11:26, Krzysztof Kozlowski wrote:
On 01/12/2022 05:46, Saravanan Sekar wrote:
The MPQ7932 is a power management IC designed to operate from 5V buses to
power a variety of Advanced driver-assistance system SOCs. Six integrated
buck converters with hardware monitoring capability powers a variety of
target rails configurable over PMBus interface.
Signed-off-by: Saravanan Sekar <saravanan@xxxxxxxxxxx>
---
drivers/hwmon/pmbus/Kconfig | 10 +++
drivers/hwmon/pmbus/Makefile | 1 +
drivers/hwmon/pmbus/mpq7932.c | 144 ++++++++++++++++++++++++++++++++++
3 files changed, 155 insertions(+)
create mode 100644 drivers/hwmon/pmbus/mpq7932.c
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you again for your time for review.
I saw two comments from you on V1 which I believe addressed on V2
1. Missing maybe_unused, so drop of_match_ptr.
".of_match_table = of_match_ptr(mpq7932_of_match)"
dropped of_match_ptr.
2. It's a regulator, not hwmon.
"config SENSORS_MPQ7932_REGULATOR
tristate "MPS MPQ7932 buck regulator" "
It is PMIC chip with hwmon support access over PMBUS.
Please help if anything I missed
Thank you.
Best regards,
Krzysztof
