RE: [PATCH] arm64: dts: renesas: rzg2l-smarc: Enable ADV7535 on carrier board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

> Subject: Re: [PATCH] arm64: dts: renesas: rzg2l-smarc: Enable ADV7535 on
> carrier board
> 
> Hi Biju,
> 
> On Thu, Dec 1, 2022 at 10:45 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > > Subject: Re: [PATCH] arm64: dts: renesas: rzg2l-smarc: Enable
> > > ADV7535 on carrier board On Thu, Dec 1, 2022 at 10:20 AM Biju Das
> > > <biju.das.jz@xxxxxxxxxxxxxx>
> > > wrote:
> > > > > Subject: Re: [PATCH] arm64: dts: renesas: rzg2l-smarc: Enable
> > > > > ADV7535 on carrier board On Tue, Nov 22, 2022 at 8:55 PM Laurent
> > > > > Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> > > > > > On Tue, Nov 22, 2022 at 07:41:13PM +0000, Biju Das wrote:
> > > > > > > > Subject: Re: [PATCH] arm64: dts: renesas: rzg2l-smarc:
> > > > > > > > Enable
> > > > > > > > ADV7535 on carrier board On Tue, Nov 22, 2022 at
> > > > > > > > 06:58:02PM
> > > > > > > > +0000, Biju Das wrote:
> > > > > > > > > Enable ADV7535 (MIPI DSI Receiver with HDMI Transmitter)
> > > > > > > > > on RZ/G2L SMARC EVK.
> > > > > > > > >
> > > > > > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > > > >
> > > > > > > > > --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> > > > > > > > > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> > >
> > > > > > > > > +
> > > > > > > > > +         ports {
> > > > > > > > > +                 #address-cells = <1>;
> > > > > > > > > +                 #size-cells = <0>;
> > > > > > > > > +
> > > > > > > >
> > > > > > > > How about port@0 ? That's the DSI input, I expect it
> > > > > > > > should be connected to the DSI encoder output.
> > > > > > >
> > > > > > > Yes, I will enable DSI node and link with port@0.  Since
> > > > > > > both RZ/G2L and RZ/V2L uses same Carrier board, I need to
> > > > > > > send binding patch for
> > > > > RZ/V2L.
> > > > > > >
> > > > > > > dts Patches for enabling DSI for RZ/G2L ready. But V2L there
> > > > > > > is
> > > > > dependency on bindings.
> > > > >
> > > > > That's just a matter of days, right?
> > > >
> > > >
> > > > >
> > > > > > > If you prefer both ports together, then I can defer this
> later.
> > > > > >
> > > > > > It could be easier to review (not to mention testing). I'll
> > > > > > let Geert decide.
> > > > >
> > > > > Is there any advantage in applying this patch now, i.e. does it
> > > > > enable any working functionality?
> > > >
> > > > Currently all display/graphics functionality tested with [3]
> > > >
> > > > The advantage is,
> > > >
> > > > 1) I would like to backport graphics and display functionality to
> > > > cip
> > > kernel [2]
> > > >    as most of our customers are using this kernel.
> > > >
> > > > 2) we can test ADV driver using i2c read/write command
> > > >
> > > > 3) We can test ADV interrupts
> > > >
> > > > 4) This will reduce integration effort as we can test full display
> > > > and
> > > graphics
> > > >   functionality with [3]
> > > >
> > > > [2]
> > > >
> > > > Please share your views.
> > >
> > > And all of that is working without port@0?
> >
> > Without port@0, we can only test read/write from ADV 7535 device using
> i2c commands.
> 
> Which you can do without this patch, too, right?

Yes, that is correct.

> 
> > For full display functionality.
> >
> > 1) we need port@0 for linking to dsi
> >
> > and
> >
> > 2) We need to link dsi with du.
> 
> Then please combine this with the dsi.

OK will combine with DSI and will send next version.

Cheers,
Biju




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux