RE: [PATCH] arm64: dts: renesas: rzg2l-smarc: Enable ADV7535 on carrier board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

Thanks for the feedback.

> Subject: Re: [PATCH] arm64: dts: renesas: rzg2l-smarc: Enable ADV7535 on
> carrier board
> 
> Hi Biju,
> 
> Thank you for the patch.
> 
> On Tue, Nov 22, 2022 at 06:58:02PM +0000, Biju Das wrote:
> > Enable ADV7535 (MIPI DSI Receiver with HDMI Transmitter) on RZ/G2L
> > SMARC EVK.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi | 44
> > ++++++++++++++++++++
> >  1 file changed, 44 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> > b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> > index e180a955b6ac..01ea8759c192 100644
> > --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> > @@ -16,12 +16,56 @@ aliases {
> >  		serial1 = &scif2;
> >  		i2c3 = &i2c3;
> >  	};
> > +
> > +	hdmi-out {
> > +		compatible = "hdmi-connector";
> > +		type = "d";
> > +
> > +		port {
> > +			hdmi_con_out: endpoint {
> > +				remote-endpoint = <&adv7535_out>;
> > +			};
> > +		};
> > +	};
> >  };
> >
> >  &cpu_dai {
> >  	sound-dai = <&ssi0>;
> >  };
> >
> > +&i2c1 {
> > +	pinctrl-0 = <&i2c1_pins>;
> > +	pinctrl-names = "default";
> > +
> > +	status = "okay";
> > +
> > +	adv7535: hdmi@3d {
> > +		compatible = "adi,adv7535";
> > +		reg = <0x3d>;
> > +
> > +		avdd-supply = <&reg_1p8v>;
> > +		dvdd-supply = <&reg_1p8v>;
> > +		pvdd-supply = <&reg_1p8v>;
> > +		a2vdd-supply = <&reg_1p8v>;
> > +		v3p3-supply = <&reg_3p3v>;
> > +		v1p2-supply = <&reg_1p8v>;
> > +
> > +		adi,dsi-lanes = <4>;
> > +
> > +		ports {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +
> 
> How about port@0 ? That's the DSI input, I expect it should be connected
> to the DSI encoder output.

Yes, I will enable DSI node and link with port@0.  Since both RZ/G2L and RZ/V2L
uses same Carrier board, I need to send binding patch for RZ/V2L.

dts Patches for enabling DSI for RZ/G2L ready. But V2L there is dependency on bindings.

If you prefer both ports together, then I can defer this later.

Cheers,
Biju

> 
> > +			port@1 {
> > +				reg = <1>;
> > +				adv7535_out: endpoint {
> > +					remote-endpoint = <&hdmi_con_out>;
> > +				};
> > +			};
> > +		};
> > +	};
> > +};
> > +
> >  &i2c3 {
> >  	pinctrl-0 = <&i2c3_pins>;
> >  	pinctrl-names = "default";
> 
> --
> Regards,
> 
> Laurent Pinchart




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux