On 2022/11/30 23:24, Rob Herring wrote: > On Tue, Nov 22, 2022 at 09:22:03PM +0800, Walker Chen wrote: >> On 2022/11/21 18:13, Krzysztof Kozlowski wrote: >> > On 18/11/2022 14:32, Walker Chen wrote: >> >> Add bindings for the power domain controller on the StarFive JH71XX SoC. >> >> >> > >> > Subject: drop second, redundant "bindings". >> >> Will fix. >> >> > >> >> Signed-off-by: Walker Chen <walker.chen@xxxxxxxxxxxxxxxx> >> >> --- >> >> .../bindings/power/starfive,jh71xx-power.yaml | 46 +++++++++++++++++++ >> > >> > 1st patch should be squashed here. Headers are part of bindings file. >> >> Will be done in the next version of patch. >> >> > >> >> 1 file changed, 46 insertions(+) >> >> create mode 100644 Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml >> >> >> >> diff --git a/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml b/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml >> >> new file mode 100644 >> >> index 000000000000..2537303b4829 >> >> --- /dev/null >> >> +++ b/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml >> > >> > Filename like compatible. >> >> As mentioned in the previous email, the compatible in the driver should be changed to "starfive,jh7110-power". > > Is the h/w block called 'power' or 'pmu'? Call it what the h/w is > called. h/w block is called PMU, is the abbreviation of Power Management Unit. It is more appropriate to change the compatile to 'starfive,jh7110-pmu'. Best Regards, Walker Chen