On 2022/11/21 18:13, Krzysztof Kozlowski wrote: > On 18/11/2022 14:32, Walker Chen wrote: >> Add bindings for the power domain controller on the StarFive JH71XX SoC. >> > > Subject: drop second, redundant "bindings". Will fix. > >> Signed-off-by: Walker Chen <walker.chen@xxxxxxxxxxxxxxxx> >> --- >> .../bindings/power/starfive,jh71xx-power.yaml | 46 +++++++++++++++++++ > > 1st patch should be squashed here. Headers are part of bindings file. Will be done in the next version of patch. > >> 1 file changed, 46 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml >> >> diff --git a/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml b/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml >> new file mode 100644 >> index 000000000000..2537303b4829 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml > > Filename like compatible. As mentioned in the previous email, the compatible in the driver should be changed to "starfive,jh7110-power". > >> @@ -0,0 +1,46 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/power/starfive,jh71xx-power.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH71xx Power Domains Controller >> + >> +maintainers: >> + - Walker Chen <walker.chen@xxxxxxxxxxxxxxxx> >> + >> +description: | >> + StarFive JH71xx SoCs include support for multiple power domains which can be >> + powered on/off by software based on different application scenes to save power. >> + >> +properties: >> + compatible: >> + items: > > No items. You have just one item, Yes, this issue will be fixed. Thank you for your advice. Best Regards, Walker Chen
