Re: [PATCH v8 4/4] hwmon: (max6639) Add pwm support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On 29-11-2022 10:11 pm, Guenter Roeck wrote:
On 11/29/22 08:34, Uwe Kleine-König wrote:
On Tue, Nov 29, 2022 at 05:11:34PM +0100, Naresh Solanki wrote:
Add pwm support for max6639. Also configure pwm fan speed based on pwm
provided in DT.

Did you do anything to resolve the questions I had in reply to v5? If
yes, I must have missed it.
I did split the patch to separate dt changes & pwm specific changes.


I don't see a response to my concerns either, especially regarding fan mode
(dc vs. pwm) in the bindings. For that reason, I won't even look at the series.

I intend to use max6639 driver but with DT support.
Did additional changes(like using PWM provider) based on feedback I received.


Guenter

Note that maintainer time is scarce and with sending new versions of a
patch with no sign that you improved in the aspects that were critized
before, you're burning that scarce time and loosing the good will of the
responsible maintainers.

Best regards
Uwe


Regards,
Naresh



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux