Hi Krzysztof, On Mon, 2022-11-28 at 10:13 +0100, Krzysztof Kozlowski wrote: > On 28/11/2022 03:06, Xiangsheng Hou wrote: > > Split MediaTek ECC engine with rawnand controller and convert to > > YAML schema. > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mtd/mtk,nand-ecc- > > engine.yaml > > Wrong vendor prefix. Isn't it mediatek? Yes, will be fixed. > > + > > + reg: > > + items: > > + - description: Base physical address and size of ECC. > > + > > + interrupts: > > + items: > > + - description: ECC interrupt > > + > > + clocks: > > + minItems: 1 > > Drop minItems. > > > + items: > > + - description: clock used for the controller > > Drop items/description - it is obvious, isn't it? Rather maxItems: 1, > Unless controller is not obvious in this context - about which > controller you talk about? Will be dropped and fix other comment in next series. > > + > > + > > + nand-ecc-engine: > > + description: Required ECC Engine node > > + $ref: /schemas/types.yaml#/definitions/phandle > > This does not look right. This is a property of NAND chip and > original > binding was saying this as well... or was it called ecc-engine in > original bindings? But your commit msg did not explain any > differences > from pure conversion. The MediaTek NAND controller driver have change ecc-engine to nand-ecc- engine property. Will dropped and explain the difference in commit msg. Best regards, Xiangsheng Hou
