Hi,
On Fri, Nov 25, 2022 at 1:44 AM Owen Yang <ecs.taipeikernel@xxxxxxxxx> wrote:
>
> Add an entry in the device tree binding for sc7280-zombie.
Probably not worth spinning the patch for, but previously [0] Matthias
requested that you say "Add entries" instead of "Add an entry". Please
don't ignore reviewer feedback.
> Signed-off-by: Owen Yang <ecs.taipeikernel@xxxxxxxxx>
> ---
>
> (no changes since v1)
Also not worth spinning the patch for, but your version history is
lacking for this patch.
The way patman works is that each patch should have its own version
history. Thus in patch #1 you could have had:
Series-changes: 2
- Adding "(newest rev)" for zombie entry description in qcom.yaml, as
requested by Douglas.
- Adding "dt-bindings: arm: qcom:" in bind patch ${SUBJECT}, as
requested by Douglas
- Changing Patch order, binding patch first and dt file second, as
requested by Douglas
Series-changes: 3
- Droping changing file path in description. v3. as requested by Matthias
Series-changes: 4
- Dropping the redundant 'DT binding for' as requested by Krzysztof
In patch #2 you would have done similar things but describe the things
that happened to _that_ patch. Make sense? Note that "Series-changes"
is different from some of the other tags in patman. Series-version
should only be listed in one patch. I believe Series-to and Series-cc
can be listed in multiple patches but they are all glommed together
into one list.
> Documentation/devicetree/bindings/arm/qcom.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
[0] https://lore.kernel.org/r/Y3zZWWCJ8aYphD7f@xxxxxxxxxx/
