On 25/11/2022 18:06, Alim Akhtar wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx] >> Sent: Friday, November 25, 2022 4:52 PM >> To: Lee Jones <lee@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; >> Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Alim Akhtar >> <alim.akhtar@xxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; linux- >> kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- >> samsung-soc@xxxxxxxxxxxxxxx >> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>; Sriranjani P >> <sriranjani.p@xxxxxxxxxxx>; Chanho Park <chanho61.park@xxxxxxxxxxx>; >> Sam Protsenko <semen.protsenko@xxxxxxxxxx> >> Subject: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add > dedicated >> SYSREG compatibles to Exynos5433 >> >> Exynos5433 has several different SYSREGs, so use dedicated compatibles for >> them. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> >> --- >> >> Cc: Sriranjani P <sriranjani.p@xxxxxxxxxxx> >> Cc: Chanho Park <chanho61.park@xxxxxxxxxxx> >> Cc: Sam Protsenko <semen.protsenko@xxxxxxxxxx> >> --- >> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++- >> 1 file changed, 12 insertions(+), 1 deletion(-) >> >> diff --git >> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- >> sysreg.yaml >> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- >> sysreg.yaml >> index 68064a5e339c..42357466005e 100644 >> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- >> sysreg.yaml >> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- >> sysre >> +++ g.yaml >> @@ -17,10 +17,21 @@ properties: >> - samsung,exynos3-sysreg >> - samsung,exynos4-sysreg >> - samsung,exynos5-sysreg >> - - samsung,exynos5433-sysreg >> - samsung,exynos850-sysreg >> - samsung,exynosautov9-sysreg >> - const: syscon >> + - items: >> + - enum: >> + - samsung,exynos5433-cam0-sysreg >> + - samsung,exynos5433-cam1-sysreg >> + - samsung,exynos5433-disp-sysreg >> + - samsung,exynos5433-fsys-sysreg >> + - const: samsung,exynos5433-sysreg >> + - const: syscon >> + - items: >> + - const: samsung,exynos5433-sysreg >> + - const: syscon >> + deprecated: true > Any reason to add "deprecated: true" here for above compatible? Because it should be used alone as unspecific. Best regards, Krzysztof