On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > Exynos5433 has several different SYSREGs, so use dedicated compatibles > for them. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > --- > > Cc: Sriranjani P <sriranjani.p@xxxxxxxxxxx> > Cc: Chanho Park <chanho61.park@xxxxxxxxxxx> > Cc: Sam Protsenko <semen.protsenko@xxxxxxxxxx> > --- Hi Krzysztof, Just curious: what is the rationale for adding those more specific sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have pretty much the same register layout. Other than that: Reviewed-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx> > .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > index 68064a5e339c..42357466005e 100644 > --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml > @@ -17,10 +17,21 @@ properties: > - samsung,exynos3-sysreg > - samsung,exynos4-sysreg > - samsung,exynos5-sysreg > - - samsung,exynos5433-sysreg > - samsung,exynos850-sysreg > - samsung,exynosautov9-sysreg > - const: syscon > + - items: > + - enum: > + - samsung,exynos5433-cam0-sysreg > + - samsung,exynos5433-cam1-sysreg > + - samsung,exynos5433-disp-sysreg > + - samsung,exynos5433-fsys-sysreg > + - const: samsung,exynos5433-sysreg > + - const: syscon > + - items: > + - const: samsung,exynos5433-sysreg > + - const: syscon > + deprecated: true > > reg: > maxItems: 1 > -- > 2.34.1 >
