On Fri, Nov 25, 2022 at 04:54:12PM +0800, Binbin Zhou wrote: > Add support for the ACPI-based device registration, so that the driver > can be also enabled through ACPI table. ... > +/* get i2c-gpio props from DT or ACPI table */ Get ... > - if (np) { > - of_i2c_gpio_get_props(np, pdata); > + if (np || has_acpi_companion(dev)) { > + i2c_gpio_get_props(dev, pdata); if (dev_fwnode() { i2c_gpio_get_props(dev, pdata); ... > + {"LOON0005", 0}, /*LoongArch*/ ", 0" part is redundant. Also missing spaces in the comment. -- With Best Regards, Andy Shevchenko