On 24/11/2022 16:38, Tomer Maimon wrote: > Hi Krzysztof, > > Thanks a lot for your comments. > > On Wed, 23 Nov 2022 at 12:03, Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> On 22/11/2022 21:12, Tomer Maimon wrote: >> >> 1. Subject: drop second, redundant "documentation" (dt-bindings are >> documentation). > O.K. >> >> 2. Use subject prefixes matching the subsystem (git log --oneline -- ...). > this is what I did dt-binding: soc: nuvoton... do you mean dt-binding: nuvoton. You didn't run the command, did you? >> >>> Added device tree binding documentation for Nuvoton BMC NPCM BIOS Post >>> Code (BPC). >>> (...) >> >> No, only bus schemas could have it. Here additionalProperties: false. >> >> It seems there are already few LPC controllers and all are put in >> different places: >> Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml >> Documentation/devicetree/bindings/arm/hisilicon/low-pin-count.yaml >> >> Maybe Rob why this was made not really as two bindings - for bus >> controller and devices? > As mention above, next patch I will describe only the BPC device. >> >> Best regards, >> Krzysztof >> > > In general, I waiting for Arnd approval for adding the NPCM BPC driver to SoC. > After Arnd approval, I will send a new patch revision. To be clear - bindings must be accepted (Reviewed or Acked) before driver is. Best regards, Krzysztof
