From: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxxxxx> The Goodix touchscreen controller has a reset line active low. It happens to also be used to configure its i2c address at runtime. If the reset line is incorrectly asserted, the address will be wrongly configured. This cost me a few hours, trying to figure out why the touchscreen wouldn't work. The driver is "asserting" this reset GPIO by setting its output to 0, probably to reflect the physical state of the line. However, this relies on the fact that the Device Tree node setting the reset line polarity to active high, which is incorrect since the reset is active low in hardware. To fix this inconsistency, the polarity is inverted to not confuse the user about the reset line polarity. This is marked as RFC because it breaks DT compatibility and I cannot test ACPI support. Do we also make this patch series only one patchset since the DT patches depend on the driver patch and vice-versa? In which tree would this go? I'm all ears if there's a better way to handle this. We could document this in the DT binding but this kinda breaks the promise we make that the DT is not bound to the driver implementation. Thanks, Quentin To: Bastien Nocera <hadess@xxxxxxxxxx> To: Hans de Goede <hdegoede@xxxxxxxxxx> To: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> To: Rob Herring <robh+dt@xxxxxxxxxx> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> To: Shawn Guo <shawnguo@xxxxxxxxxx> To: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> To: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx> To: Fabio Estevam <festevam@xxxxxxxxx> To: NXP Linux Team <linux-imx@xxxxxxx> To: Chen-Yu Tsai <wens@xxxxxxxx> To: Jernej Skrabec <jernej.skrabec@xxxxxxxxx> To: Samuel Holland <samuel@xxxxxxxxxxxx> To: Andy Gross <agross@xxxxxxxxxx> To: Bjorn Andersson <andersson@xxxxxxxxxx> To: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx> To: Heiko Stuebner <heiko@xxxxxxxxx> Cc: linux-input@xxxxxxxxxxxxxxx Cc: linux-kernel@xxxxxxxxxxxxxxx Cc: devicetree@xxxxxxxxxxxxxxx Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx Cc: linux-sunxi@xxxxxxxxxxxxxxx Cc: linux-arm-msm@xxxxxxxxxxxxxxx Cc: linux-rockchip@xxxxxxxxxxxxxxxxxxx Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxxxxx> --- Changes in v2: - implemented ACPI support as suggested by Hans, - removed Qcom SC7180 Trogdor-based devices changes as they are not using this Goodix driver, - added comment on how to read gpiod_request_output and the GPIO DT polarity, - Link to v1: https://lore.kernel.org/r/20221103-upstream-goodix-reset-v1-0-87b49ae589f1@xxxxxxxxxxxxxxxxxxxxx --- Quentin Schulz (7): Input: goodix - fix reset polarity ARM: dts: imx: fix touchscreen reset GPIO polarity ARM: dts: sunxi: fix touchscreen reset GPIO polarity arm64: dts: allwinner: fix touchscreen reset GPIO polarity arm64: dts: imx: fix touchscreen reset GPIO polarity arm64: dts: qcom: fix touchscreen reset GPIO polarity arm64: dts: rockchip: fix touchscreen reset GPIO polarity arch/arm/boot/dts/imx6q-kp.dtsi | 2 +- arch/arm/boot/dts/imx6ul-kontron-bl-43.dts | 2 +- arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 2 +- .../dts/allwinner/sun50i-a64-amarula-relic.dts | 2 +- .../allwinner/sun50i-a64-oceanic-5205-5inmfd.dts | 2 +- .../boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 2 +- .../boot/dts/allwinner/sun50i-a64-pinetab.dts | 2 +- arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts | 2 +- .../boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +- arch/arm64/boot/dts/qcom/msm8998-fxtec-pro1.dts | 2 +- arch/arm64/boot/dts/rockchip/px30-evb.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 2 +- arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts | 2 +- drivers/input/touchscreen/goodix.c | 45 +++++++++++++++++----- 14 files changed, 48 insertions(+), 23 deletions(-) --- base-commit: 84368d882b9688bfac77ce48d33b1e20a4e4a787 change-id: 20221103-upstream-goodix-reset-aa1c65994f57 Best regards, -- Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxxxxx>
