On 21/11/2022 12:38, Emil Renner Berthing wrote: > On Mon, 21 Nov 2022 at 09:49, Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> On 18/11/2022 02:06, Hal Feng wrote: >>> From: Emil Renner Berthing <kernel@xxxxxxxx> >>> >>> Add bindings for the always-on clock and reset generator (AONCRG) on the >>> JH7110 RISC-V SoC by StarFive Ltd. >>> >>> Signed-off-by: Emil Renner Berthing <kernel@xxxxxxxx> >>> Signed-off-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> >>> --- >>> .../clock/starfive,jh7110-aoncrg.yaml | 76 +++++++++++++++++++ >>> 1 file changed, 76 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/clock/starfive,jh7110-aoncrg.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/clock/starfive,jh7110-aoncrg.yaml b/Documentation/devicetree/bindings/clock/starfive,jh7110-aoncrg.yaml >>> new file mode 100644 >>> index 000000000000..afbb205e294f >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/clock/starfive,jh7110-aoncrg.yaml >>> @@ -0,0 +1,76 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/clock/starfive,jh7110-aoncrg.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: StarFive JH7110 Always-On Clock and Reset Generator >>> + >>> +maintainers: >>> + - Emil Renner Berthing <kernel@xxxxxxxx> >>> + >>> +properties: >>> + compatible: >>> + const: starfive,jh7110-aoncrg >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + clocks: >>> + items: >>> + - description: Main Oscillator >>> + - description: RTC clock >> >> Real Time Clock clock? :) I don't think the input to clock controller is >> the output of RTC... > > The description is bad, but even the documentation calls it "clk_rtc" > even though it's really an optional input from a 32k oscillator. Then description should match reality, not documentation. Documentation is often poor, so if possible better to extend it. Best regards, Krzysztof
