On Mon, 21 Nov 2022 12:32:24 +0100, Emil Renner Berthing wrote: > On Mon, 21 Nov 2022 at 08:16, Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> wrote: > > > > On Sat, 19 Nov 2022 00:26:27 +0800, Emil Renner Berthing wrote: > > > On Fri, 18 Nov 2022 at 02:06, Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> wrote: > > > > > > > > Rename "clk-starfive-jh7100.h" to "clk-starfive-jh71x0.h" and rename > > > > some variables from "jh7100" or "JH7100" to "jh71x0" or "JH71X0". > > > > > > > > Co-developed-by: Emil Renner Berthing <kernel@xxxxxxxx> > > > > > > The patch is fine, but I'm a little unsure about this Co-developed-by. > > > This patch is taken directly from my jh7110 branch so does Hal sending > > > it count as co-developed-by? > > > > Your original patch merged patch 1 and patch 2. Suggested by Stephen, I > > split the patch into two patches, and I need to add a new commit. My > > previous thinking was that the Co-developed-by tag should not be added > > to the commit author, so I added it to you. > > Even if you didn't just copy it[1] I still don't think splitting > patches counts as "developed by". You can set the author of new > commits or copy them from a previous commit with git commit -c. Okay, I will remove my Co-developed-by tag in patch 1, 2, 4, 5 and set the commit author as you. > > [1]: https://github.com/esmil/linux/commit/df4bcbc307e97cb6a0e7b8ed5ecc66487395176d Oh, I don't even know you still work on JH7110 and update on github.. All your patches were cherry-picked from your gitlab branch. There is no doubt that we did the same thing for this patch. Best regards, Hal
