Hi Anand,
On 11/16/22 21:01, Anand Moon wrote:
> On rk356x ethernet phy support reduced media independent interface (RMII)
> and reduced gigabit media independent interface (RGMII).
> So set the phy mode to rgmii to support clock delay, also
> add TX and RX delay for phy-mode.
Based on this commit message I still don't understand what you are
actually trying to fix here. If you encounter network problems/stability
issues, please let me know what test triggers the faulty behavior.
Please describe the problem you are facing in detail here or in the
cover letter.
> Fix following warning
>
> [ 7.365215] rk_gmac-dwmac fe010000.ethernet: Can not read property: tx_delay.
> [ 7.365219] rk_gmac-dwmac fe010000.ethernet: set tx_delay to 0x30
> [ 7.365224] rk_gmac-dwmac fe010000.ethernet: Can not read property: rx_delay.
> [ 7.365228] rk_gmac-dwmac fe010000.ethernet: set rx_delay to 0x10
If the only purpose of this patch is to get rid of this warnings, it may
make sense to set them to dev_dbg as Peter pointed out.
Best regards,
Michael
>
> Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx>
> ---
> V2: Fix commit message and added the RX and TX clock delay.
> ---
> arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> index ea74ba32fbbd..e1c75532dcee 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> @@ -253,13 +253,16 @@ &gmac1 {
> assigned-clock-rates = <0>, <125000000>;
> clock_in_out = "output";
> phy-handle = <&rgmii_phy1>;
> - phy-mode = "rgmii-id";
> + phy-mode = "rgmii";
> pinctrl-names = "default";
> pinctrl-0 = <&gmac1m1_miim
> &gmac1m1_tx_bus2
> &gmac1m1_rx_bus2
> &gmac1m1_rgmii_clk
> &gmac1m1_rgmii_bus>;
> +
> + tx_delay = <0x4f>;
> + rx_delay = <0x26>;
> status = "okay";
> };
>
